Page 1 of 1
Forum

Welcome to the Tweaking4All community forums!
When participating, please keep the Forum Rules in mind!

Topics for particular software or systems: Start your topic link with the name of the application or system.
For example “MacOS X – Your question“, or “MS Word – Your Tip or Trick“.

Please note that switching to another language when reading a post will not bring you to the same post, in Dutch, as there is no translation for that post!




Name My TV Series 1...
 
Share:
Notifications
Clear all

Name My TV Series 1.7.x discussion

Page 1 / 3

 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

I started this topic based on beta testing v1.7.x of Name My TV Series (see these comments under the Name My TV Series article)


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

I'll try to post some of the comments here.


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

1) Import/Export, extra space; fixed, space removed. My bad ....  

2) Populate both lists, click “clear” on right list. Then click “remove” - Had run into this as well, fixed!  

3) After newly opening app, not adhering to format selected in last session. - todo.  

4) Rename file to name it already has. Use windows API MoveFileW instead?- todo. Do I understand this right? I could check if newname=oldname and only rename if needed.  

I'm developing using Lazarus Pascal ... in case you were wondering . It allows me to develop for multiple platforms at once.  

Not quite sure what you meant with (it's early in the morning here haha, need more coffee):  

1. Using the new “history” dropdown for shows, add 4 diff episodes – one from each show   

2. Add one local folder with 4 shows single episodes to match   

Now, upon the new popup for ffprobe, when it completes probing, it has incorrectly changed the left list of 4 episodes from 4 shows to actually read as the same 4 unique ep names, but now all from the last single SHOW name selected. So instead of: Show1.pilot part 1 Show2.super cool episode After the probe, it reads: Show1.pilot part 1 Show1.super cool episode .


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

Naturally, thank you mdo_security, bbPress, etc etc ... I couldn't post you comments due to some security issue haha ... magical combination of words rejected your comments in the forum - so I had to dig in the security config of my webserver first ...  Argh ... need more coffee! 


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

Hi Collin,

I'm going through the bugs you've found, one at a time, but was unable to reproduce:

"Upon 1st open of app, even if the “remembered” naming template (all of mine do) are set to add periods instead of spaces, the show and episode name wrongfully is missing the periods and instead has spaces. I know because I didn’t realize until 10 big seasons done, and am going back now to redo them all."

So as I understand; you create a new "template" for the filename, with periods in it instead of spaces.
Rename a file or two. CLose the app. Open the app, load a show and try renaming again, but the template is not being used, unless you go into preferences and re-select the one you want to use (which shows as selected to begin with)?

When I try that (on Mac and Windows), it just works. Did I misunderstand this one?


ReplyQuote


 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

Just modified the rename procedure;

If a the "new file" already exists, or the uppercase(New filename) = uppercase(Old filename), then renaming is begin skipped.
I hope that will address the rename issue you mentioned.


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

Coming back to the rename of (for example) episode.s1.e2.avi to Episode.S1.E2.avi ... with the old code I cannot reproduce the error you mentioned (Windows 10). It actually does what is expected, the result being Episode.S1.E2.avi.

Which Windows version are you using?


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

OK found the issue with this one:

1. Using the new “history” dropdown for shows, add 4 diff episodes – one from each show 

2. Add one local folder with 4 shows single episodes to match 

Now, upon the new popup for ffprobe, when it completes probing, it has incorrectly changed the left list of 4 episodes from 4 shows to actually read as the same 4 unique ep names, but now all from the last single SHOW name selected. 

So instead of: Show1.pilot part 1 Show2.super cool episode After the probe, it reads: Show1.pilot part 1 Show1.super cool episode

The problem lies in the design ... the text field "Series Title" under "Select Episodes" is used to name the show. So users can modify the show name to their liking. I never designed it to rename numerous shows all at once.

Let me see if I can still change that without too much work 


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

OK, that last one is going to have a significant impact.
This would require a redesign that will take a lot of time. Maybe something for v2.0. Unless I suddenly get a bright moment ... 


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

OK, bright moment kicked in ... solved that one too ... 


ReplyQuote


 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

Remaining (if I read all this right):

- Renaming files with the same name

For example episode.s1.e1.avi -> Episode.S1.E1.avi fails, but I cannot reproduce that one. I did however remove the security check which checks if a file already exists, throwing the error. Further testing needed.

- Remembered template not honored when starting app

I was unable to reproduce that one ... please let me know if I understood this one right.
So you define a template and use it. Close app. Open app, try to rename, but template is not used. Going in to Preferences, and "re-select" the template fixes it as a work around.


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

This is the MacOS X version, with the mentioned bugs fixed.

Windows version will follow shortly (my Internet connect sucks)....


ReplyQuote
 Hans
(@hans)
Noble Member Admin
Joined: 8 years ago
Posts: 2012
Topic starter  

Since the Windows version is much larger than the Mac version ... 3rd attempt, but not as an attachment.

You can download the Windows version here.


ReplyQuote
(@collin)
Active Member
Joined: 5 years ago
Posts: 7
 

Hey Hans,

So sorry I've been offline.  Wow!  Awesome work getting this much done!

Let me catch up right now on all these threads it looks like there still may be one or two you were unable to reproduce that I may have to revisit again as well.

Thanks!

Collin


ReplyQuote
(@collin)
Active Member
Joined: 5 years ago
Posts: 7
 

The  "Renaming files with the same name" - from what I can tell, it may simply be that you had a check running for "existing", since the upper and lowercase would still be considered the exact same name.  All I can tell unless there is a way to turn on some type of debug output/logging, is that if any rename in the list is to an existing name (but in my cases just with a different case), then the entire rename operation comes back with an error and a "do you wish to continue" which still winds up failing.  If I rename the one(s) in question that are already named to the same as the proposed new (albeit with a different CASE), then the entire naming operation(s) succeed.  Does that help at all?

For the "Remembered template not honored when starting app" let me rerun some tests but I was running into this consistently one evening where the only templates I had defined were set and had punctuation options to supply periods instead of spaces, but the renames (and the displayed preview) would contain spaces not periods until I simply went into options, and reselected the exact same template again.  Then, closing that options window instantly would change the previewed (and actual) new names to periods and not spaces.  Again this was not even changing to different template, and none of my templates ever use spaces, so that one other than this description I had a hard time describing.  I will try a little later to maybe try to reproduce again and if I can, do a video screen cap and post it to maybe an unlisted youtube link for you to view.  Same with any other bugs it may be easier and quicker if I can possibly just give you the visual of it as well.

Let me grab the new build you put up and run it through paces though and using that new codebase, see if this bug can even be reproduced anymore before we spend any more time on it!


ReplyQuote


Page 1 / 3

Like what you see and you'd like to help out? 

The best way to help is of course by assisting others with their questions here in the forum, but you can also help us out in other ways:

- Do your shopping at Amazon, it will not cost you anything extra but may generate a small commission for us,
- send a cup of coffee through PayPal ($5, $10, $20, or custom amount),
- become a Patreon,
- donate BitCoin (BTC), or BitCoinCash (BCH).

Share: