Page 1 of 1
Forum

Welcome to the Tweaking4All community forums!
When participating, please keep the Forum Rules in mind!

Topics for particular software or systems: Start your topic link with the name of the application or system.
For example “MacOS X – Your question“, or “MS Word – Your Tip or Trick“.

Please note that switching to another language when reading a post will not bring you to the same post, in Dutch, as there is most likely no translated for the post!





Rename My TV Series...
 
Share:
Notifications
Clear all

Rename My TV Series 2.x - Application Log?  

Page 3 / 4
  RSS

kilimar
(@kilimar)
Eminent Member
Joined: 3 months ago
Posts: 30
June 22, 2020 11:41 PM  
Posted by: @kilimar

Looks like when "Update or add metadata in video file" is enabled, it stripped one (or more) of the audio streams from the video file. I had a files with two audio streams and when the rename was complete, only one audio stream was shown in VLC/MediaInfo.

Looks like the "Update or Add Metadata in video file" option also strips all but one text steams as well.

 

Feature Request: If the application can't just "insert" the metadata and has to re-write all streams, then perhaps include the ability to discard streams.  In particular, discarding certain audio streams since those would be much larger than the text streams; or so I would think.

This post was modified 2 months ago by kilimar

ReplyQuote
Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
June 23, 2020 4:43 AM  

And here I thought I had posted a reply to your previous comments 😱  - apologies for that.

Good that you're reporting this. This was not the behavior I had in mind at all.
I had not noticed this, maybe I did something wrong with the script - I'm running ffmpeg instead of accessing a DLL.

Selecting streams is something I'd rather not implement. This was only intended as a nicety to only handful of users, and I'd rather not make RMTV more complex - things are getting out of hand as it is.

Inplace inserting into the file is not how ffMPEG handles this, and to be fair, this wouldn't work anyway. Too much data would need to be shifted in the file to make the metadata fit. So instead of storing the entire file in memory, it would be easier to write to a new file. This is also something I prefer anyway, just to avoid that the original file gets damaged.

I'll try to do some testing in the next 2 days, see what I can come up with.
Thanks again for excellent bug reporting! 👍 


ReplyQuote
kilimar
(@kilimar)
Eminent Member
Joined: 3 months ago
Posts: 30
June 23, 2020 11:48 AM  

I didn't think it was possible but with zero knowledge..... had to ask.  :)  Probably to save space in video container/format, the format would not allocate a block of space if the metadata has no max or very large max size...

 

Would a command line parameter string, in addition to or instead of the 'hidden' metadata ones, for ffmpeg would give users (like me) more flexibility without adding additional load to the program. 

 

Perhaps log to a console, similar to the Autodetect Log, when calling external programs?

This post was modified 2 months ago by kilimar

ReplyQuote
Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
June 25, 2020 4:58 AM  

I'm sure that is exactly the reason why no space is allocated for metadata.

Maybe I goofed up, I'll have to try to find time to look into this. I'm sure ffMPEG has options to avoid this from happening.

I could dump some data in the Autodetect log - but here again, I'll have to look and see.
With adding metadata, the text output is not (usually) very interesting, so I may not be catching that in my code.

Unfortunately, this week has been quite busy, so I didn't get to it yet 😣 


ReplyQuote
kilimar
(@kilimar)
Eminent Member
Joined: 3 months ago
Posts: 30
July 13, 2020 3:18 AM  

No problem.  Found another issue.  When searching for Magical Sempai with TheTVDB, locks up the program.


ReplyQuote



Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
July 13, 2020 5:15 AM  

Interesting catch! I managed to reproduce the lock up ... I'll have to check and see why it locks up  🤔 
Initial testing shows it locks up while retrieving the episodes.

Thanks for reporting - I'll have to investigate this further (most likely corrupted JSON data from TheTVDB).


ReplyQuote
Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
July 13, 2020 6:42 AM  

OK, found what triggers te freeze .... in the description they added "<3", which TMDB does not.
RMTV uses a routine that removes all HTML in the episode overview text, and it gets stuck on this (the < symbol, and looking for a matching >).


ReplyQuote
Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
July 13, 2020 7:02 AM  

Because of Apple's 🤬  notarizing process, I have to wait before I can notarize the new version.
They keep updating their "contract" which I need to sign (over and over again), which takes them a few hours to "approve" ...
As soon as I have it notarized, I'll upload the new beta with the fix for this issue (excellent catch by the way!).


ReplyQuote
Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
July 13, 2020 7:40 AM  

I've just uploaded the macOS version - later today I'll add Windows and Linux.


ReplyQuote
Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
July 13, 2020 11:10 AM  

Just uploaded the Windows version. The Linux version should follow soon (waiting for the compiler to be recompiled).

Thanks again!!! 👍 


ReplyQuote



kilimar
(@kilimar)
Eminent Member
Joined: 3 months ago
Posts: 30
July 16, 2020 3:17 AM  

Rename My TV Series: 2.1.1 (Build 9)

So it now catches the error and throws up a dialog for each case?  Actually, it seems like for every episode it is throwing up a dialog.  Did you forget to remove a debug statement?  😉 

 

 

 

This post was modified 1 month ago by kilimar

ReplyQuote
Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
July 16, 2020 5:04 AM  

Yes I goofed up 🤫 

Yesterday I uploaded a new build (10):

https://www.tweaking4all.com/home-theatre/rename-my-tv-series-v2/#BetaReleases


ReplyQuote
kilimar
(@kilimar)
Eminent Member
Joined: 3 months ago
Posts: 30
July 18, 2020 8:59 PM  

Intentional ?

 

I used inline edit on the last entry in Selected Episodes list.  The list had 24 items.  As I scrolled up and down, the edited entry stayed shown as the last item in the last row and did not scroll "away" when I scrolled up to the top.  The Selected Files scrolled properly.

 

Looks like after the Rename Files operation completed, the scrolling synced again.

This post was modified 4 weeks ago 4 times by kilimar

ReplyQuote
Hans
 Hans
(@hans)
Noble Member Admin
Joined: 7 years ago
Posts: 1443
July 19, 2020 5:04 AM  

Not sure what "intentional ?" was referring to haha ... sorry.

As for the inline-editing and scrolling ... hmm, I'll have to look into that. Under macOS it runs fine, but if I recall correctly, you're running Windows.
The lists (selected episodes and selected files) are 2 independent lists and the should sync their motion. 🤔 
The fact that the "edited" item remains visible is probably because the extra control (the edit field) isn't disappearing.
Added to my to-do list! 👍 


ReplyQuote
kilimar
(@kilimar)
Eminent Member
Joined: 3 months ago
Posts: 30
July 20, 2020 12:48 AM  
Posted by: @hans

The fact that the "edited" item remains visible is probably because the extra control (the edit field) isn't disappearing.

That does seem to be the case; I played with inline edit a bit more and it seems like the extra control isn't being 'freed' and so it's stuck.  Edit then trying to clear the list does not clear the edited item.  Also does not allow of editing a different row after the initial row.


ReplyQuote



Page 3 / 4
Share: