Page 1 of 1
Forum

Welcome to the Tweaking4All community forums!
When participating, please keep the Forum Rules in mind!

Topics for particular software or systems: Start your topic link with the name of the application or system.
For example “MacOS X – Your question“, or “MS Word – Your Tip or Trick“.

Please note that switching to another language when reading a post will not bring you to the same post, in Dutch, as there is no translation for that post!



Share:
Notifications
Clear all

[Solved] RMTVS 2.3.2 Issue

39 Posts
3 Users
5 Reactions
1,480 Views
(@thebaf)
Eminent Member
Joined: 2 months ago
Posts: 15
Topic starter  

Hi Hans,

 

      Something else I found, 

 

Select a Folder with a TV Series that has 1 Season in it and ten episodes in the season with autodetect on.

All 10 files get a name in the left column.

Select Rename files

All files get renamed and moved to target directory , however the top of the right column is stuck on "Renaming File 9 of 10" - The season subfolder is deleted (option checked in settings) but the top folder is not deleted.  Not a big deal just thought I would mention it.

 

And if I could add a feature request - it would be great to select a base directory in settings of where the collection of the files to be renamed is for those of us who don't put them in the program subdir.  And if the folder doesn't exist then send them to the app directory.

 

Rename My TV Series: 2.3.2 (Build 4)
SQLite library: v.3.50.1
OS: Windows (64 bit), Windows 10.0, x86-64 (64 bit application)
Data path: E:\Program Files\Rename My TV Series\data\

 

Thanks,

Greg


   
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

Interesting find! And thank you for reporting. Seems 9 files went correct and the 10th one got stuck? Could this be related to access rights? (just wondering)

As for the feature request; Under macOS the last used location will be used by the OS. Is Windows ignoring that?
If so then I could add something like "last used directory" and if the directory doesn't exist keep going down a directory until the path exist, and otherwise have Windows pick whatever it would pick by default. Of course, a "default video path" could be an option as well, with the optional combination to use "last used path".
Something like that?

Note : each new version takes quite a bit of work, so I'd like to combine fixes/features as much as possible. Even fixing a small bug takes quite a bit of work. I'll definitely add this to the "to do" list 👍 


   
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

Note: in the current developers build (not yet published) I've added:

- Automatically store last used directory for video imports
- Option to set a default path for video imports (overrides "last used")

Both will try to determine if the path exists, and if not, it will try to find an existing parent directory. Useful for when a temporary directory was removed but we'd like to stay in the vicinity of the original choice (last used or set default path).
Default path will always rule, if checked.

May take a bit before I release this version.
Like I said: it takes quite a bit of work to prepare a release for 4 versions (Windows, macOS, Linux GTK and QT5).


   
ReplyQuote
(@thebaf)
Eminent Member
Joined: 2 months ago
Posts: 15
Topic starter  

Hi Hans,

    No problem on waiting for the next release as I said these two items are annoyances that's all.  The getting stuck item isn't a permission problem, it renames and moves the file fine.  The app just doesn't update itself after the last move.  Your fixes for the default path sound great thanks!

 

Greg


   
Hans reacted
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

I'm wondering why that happens - I'll have to do more testing to see if I can reproduce this.
Most of my testing is done under macOS, so I'll have to do some more testing under Windows.

So I understand this is just a cosmetic annoyance. Correct me if I'm wrong.
What did you mean with "but the top folder is not deleted" (sorry for overlooking that when you first posted the bug).

Can you describe the actions and settings in more detail? Eg. rename, move, etc etc.
(sorry for being a pain - greatly appreciate you trying to help to debug things)

This post was modified 2 months ago by Hans

   
ReplyQuote
(@thebaf)
Eminent Member
Joined: 2 months ago
Posts: 15
Topic starter  

Hi Hans,

    

    So the directory tree is (TV show name is Goats in Space) 

 

 

Goats in Space

     Season 01

         Episodes for Season 01

     Season 02

         Episodes for Season 02

     and so on.

 

At the end of a rename the directory structure is copied completely correctly, the episodes are deleted , the Season folders are deleted, but the Goats in Space folder (which is what I selected) still remains.  I hope that clears it up - again - purely cosmetic and easy to live with.

 

Thanks,

Greg

 

This post was modified 2 months ago by thebaf

   
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

Ah I see, that makes sense and works as intended.
Only the directory that holds an actual episode file is removed if that option is checked, but not any of its parent directories.
If this would be allowed, I'd have RMTV walk down to the root of a drive/share and have it remove each empty directory on it's path - or at least until the directory that was dropped on RMTV.

Best I can come up with is added yet another option: Remove a dropped directory if empty after rename.
For some (you for example) this ay desirable, for others (that drop for example their "downloads" directory on RMTV) not so much.

Let me see if I can implement something like that.
Technically very doable, just have to see how much space I have left in the preferences haha. 😉 


   
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

Well, I was a little too optimistic on this one.

I can only delete the directory where the actual episode was originally located in.
Looking at parent directories comes with issues since during a rename RMTV no longer knows if just a file or a directory was dropped on it.
So I'd potentially delete too much.

To illustrate this:

Lets say we have this structure for a file:

/some/directory/path/myfiles/show1/season1

The episode file resides in "season1" and the episode gets moved away after a rename.
Now "season1" is empty and we'd like to remove that one.
So far so good, and this is how it works right now.

If I'd look at the parent "show1" then that one could now be empty as well, but I am not sure if that one should be removed.
Now lets assume we would do this (RMTV does not know if you dropped a single file, or maybe the entire "myfiles" directory, it only knows the full path of the file).

Say "myfiles" is now empty as well, should this be removed? And on and on.
I can see directory structures being removed to a level that most users would not want to.

I'm keeping this in mind though as I do understand your use case. I just do not have a good option right now without causing problems for others.


   
ReplyQuote
(@thebaf)
Eminent Member
Joined: 2 months ago
Posts: 15
Topic starter  

Hi Hans,

 

   Totally acceptable answer, I wouldn't waste any more time on the parent directory deletion issue.

 

Thanks,

Greg


   
Hans reacted
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

Your suggestions are most welcome Greg - keep 'm coming - I'll always try to find a solution if possible.
I've kept it on my ToDo list, incase I get an idea how to address this. 😉 

I still have to work on the other issue - I hope I will not forget. 😊 


   
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

Managed to reproduce the "Renaming File 9 of 10" bug. 👍 
Will try to fix that today as well.


   
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

Alrighty - got that fix and found a bug that has been there since the first version. Imagine my surprise nobody noticed it.
The file count went from 0-9 instead of 1-10 ... OMG what a silly noob mistake on my end.

Based on your findings I did revamp the detection of extra files as well (file.eng.srt, file.eng.sdh.srt, etc) as this caused an unexpected issue with files like 1.mp4 and 10.mp4 where RMTV mistakingly could see this as files that are similar named files.

Fix will be in 2.3.3 😊 


   
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

FYI: Just uploaded the 2.3.3 release 😎 


   
ReplyQuote
(@thebaf)
Eminent Member
Joined: 2 months ago
Posts: 15
Topic starter  

Hi Hans,

    2.3.3 loaded and tested.  The file renaming numbering is fixed thanks!  Looks like adding the default directory to process messes up the GUI on Generic Settings:

 

 

Thanks!

Greg


   
Hans reacted
ReplyQuote
 Hans
(@hans)
Famed Member Admin
Joined: 12 years ago
Posts: 2944
 

Hi Greg,

thanks for reporting ... fixed the issue. It's related to how Windows handles (not so great) screen scaling, and I forgot to check the option that it should not use the default font for these options (only a problem under Windows, not visible and work correct under Linux and macOS).

Anywhooo ... thank you for reporting. Fixed it and will be available with the next release (2.3.4) - which may take a few days. 😉 


   
ReplyQuote
Page 1 / 3
Share: